Development

ActivityMonitor: don't draw graph with negative width.

Source Activity - Wed, 2014-11-26 11:16
The computation of the graph width could overflow leading to an absurdly high count of lines to be drawn. This would freeze with BShape trying to realloc the array to bigger and bigger sizes as lines were added to it (by increment of 256, but still), or trigerred a bad_alloc in BeginLineArray which allocates them upfront after I converted the code to use that (it is more appropriate). Add sanity checks to avoid the overflow, now you can have hundreds of graphs without problems (much more than I can fit on my screen anyway, which I think is good enough). Fixes #6841. The computation of the graph width could overflow leading to an absurdly high count of lines to be drawn. This would freeze with BShape trying to realloc the array to bigger and bigger sizes as lines were added to it (by increment of 256, but still), or trigerred a bad_alloc in BeginLineArray which allocates them upfront after I converted the code to use that (it is more appropriate). Add sanity checks to avoid the overflow, now you can have hundreds of graphs without problems (much more than I can fit on my screen anyway, which I think is good enough). Fixes #6841.
Categories: Development

BView::BeginLineArray: leave object in consistent state

Source Activity - Wed, 2014-11-26 11:14
We allow this method to throw bad_alloc exceptions as there is no other way to report errors. However we left the object in a broken state (maxCount set, but array not initialized) which would crash when calling either AddLine or EndLineArray. Initialize the count to 0 before throwing the exception so now EndLineArray can be called and operations resumed safely after an allocation failure. We allow this method to throw bad_alloc exceptions as there is no other way to report errors. However we left the object in a broken state (maxCount set, but array not initialized) which would crash when calling either AddLine or EndLineArray. Initialize the count to 0 before throwing the exception so now EndLineArray can be called and operations resumed safely after an allocation failure.
Categories: Development

Ticket #5773 (vm_page_fault after adding graph) closed

Latest Bugs & Tasks - Wed, 2014-11-26 10:42
duplicate:

Closing this since the KDL is gone (at least here I can't reproduce that part). The freeze is tracked in #6481.

Categories: Development

Mouse prefs: truncated string in Suomi translation

Source Activity - Wed, 2014-11-26 09:57
* Set the minimal size of the double click test area so the string fits, in any language. * Fixes #5746. * Set the minimal size of the double click test area so the string fits, in any language. * Fixes #5746.
Categories: Development

Ticket #5734 (Dead key display issues) closed

Latest Bugs & Tasks - Wed, 2014-11-26 09:37
fixed:

Fixed in hrev48379.

Categories: Development

Keymap preferneces: improve deadkey handling logic

Source Activity - Wed, 2014-11-26 09:35
* The key down message is not delivered when completing a dead key, so act on key up instead. * Pressing a character after a dead key would leave the keymap in "dead key" mode, and that mode would be exited only by pressing a dead key again. Fixes #5734. * The key down message is not delivered when completing a dead key, so act on key up instead. * Pressing a character after a dead key would leave the keymap in "dead key" mode, and that mode would be exited only by pressing a dead key again. Fixes #5734.
Categories: Development

Add SerialConnect to DeskBar menu.

Source Activity - Wed, 2014-11-26 09:12
It works well enough now. It works well enough now.
Categories: Development

BOptionPopUp: build fix.

Source Activity - Wed, 2014-11-26 08:48
Categories: Development

BOptionPopUp: don't offset when there is no label.

Source Activity - Wed, 2014-11-26 08:29
We add a 8 pixel space between the label and the menu, but we shouldn't do that when the label is empty. This matches BMenuField behavior. Fixes part of #10734. We add a 8 pixel space between the label and the menu, but we shouldn't do that when the label is empty. This matches BMenuField behavior. Fixes part of #10734.
Categories: Development

HaikuWebkit 1.4.7.

Source Activity - Wed, 2014-11-26 07:22
Categories: Development
Syndicate content