Development

Tracker: Style fixes

Source Activity - Wed, 2015-02-25 21:33
Categories: Development

Ticket #11838 (regression: Tracker list view sorting order not stored anymore) closed

Latest Bugs & Tasks - Wed, 2015-02-25 20:40
no change required:

List mode was default on Haiku R1/A4 and BeOS R5 and is still the default today.

Categories: Development

Tracker: Save Desktop state again

Source Activity - Wed, 2015-02-25 20:31
Let me tell you a story about a bug. In a615ec8f86406c14607c656cf90492bc58bd73d0 Axel imported the OpenTracker code into Haiku with fSaveStateIsEnabled set to true (for Desktop and all windows). In 9f2a3f6f47d121411c85a1e939f1cda80a4b4b1d I (John) changed it to: fSaveStateIsEnabled(dynamic_cast(this) == NULL) which is suppose to detect whether or not the ContainerWindow is the Desktop and only save the state if it is NOT. However, this didn't actually work because since this is called in the constructor the dynamic_cast to BDeskWindow* fails. Therefore we were still saving the state of Desktop even though the code make it look like we weren't. In e7803cf1f69a81b1c77880518ba16b6708c1efdb Augustin updated the code so that BDeskWindow passes in a isDeskbar flag as part of the constructor parameters thus detecting that the window was Deskbar correctly. So basically Augustin fixed the bug detecting whether or not the window was the Deskbar in the constructor which then disabled saving the Desktop's state to attributes. Augustin unknowingly turned saving the Desktop's state off. We don't want to disable saving the Desktop's state because that's where we store things like the icon size. What I was probably thinking when I tried unsuccessfully to turn off saving the state of the Desktop was that I don't want to save the WINDOW state of the Desktop since that would save the window dimensions of the Desktop (whatever your screen resolution is) and if you changed Tracker to non-spatial mode and opened the Desktop in a Tracker window it would pick up those attributes and then make the window take up the entire dimensions of your screen (a whole different bug). This bug, however, is also handled in 9f2a3f6f47d121411c85a1e939f1cda80a4b4b1d because code was added to BContainerWindow::SaveWindowState() which detects whether or not the window is the Desktop and if so, doesn't save (or restore) the window state (which is only part of the state). So with this change (reversal really) the other parts of the Desktop's state like icon size are once again saved while the window state is not. Fixes #11864 Let me tell you a story about a bug. In a615ec8f86406c14607c656cf90492bc58bd73d0 Axel imported the OpenTracker code into Haiku with fSaveStateIsEnabled set to true (for Desktop and all windows). In 9f2a3f6f47d121411c85a1e939f1cda80a4b4b1d I (John) changed it to: fSaveStateIsEnabled(dynamic_cast(this) == NULL) which is suppose to detect whether or not the ContainerWindow is the Desktop and only save the state if it is NOT. However, this didn't actually work because since this is called in the constructor the dynamic_cast to BDeskWindow* fails. Therefore we were still saving the state of Desktop even though the code make it look like we weren't. In e7803cf1f69a81b1c77880518ba16b6708c1efdb Augustin updated the code so that BDeskWindow passes in a isDeskbar flag as part of the constructor parameters thus detecting that the window was Deskbar correctly. So basically Augustin fixed the bug detecting whether or not the window was the Deskbar in the constructor which then disabled saving the Desktop's state to attributes. Augustin unknowingly turned saving the Desktop's state off. We don't want to disable saving the Desktop's state because that's where we store things like the icon size. What I was probably thinking when I tried unsuccessfully to turn off saving the state of the Desktop was that I don't want to save the WINDOW state of the Desktop since that would save the window dimensions of the Desktop (whatever your screen resolution is) and if you changed Tracker to non-spatial mode and opened the Desktop in a Tracker window it would pick up those attributes and then make the window take up the entire dimensions of your screen (a whole different bug). This bug, however, is also handled in 9f2a3f6f47d121411c85a1e939f1cda80a4b4b1d because code was added to BContainerWindow::SaveWindowState() which detects whether or not the window is the Desktop and if so, doesn't save (or restore) the window state (which is only part of the state). So with this change (reversal really) the other parts of the Desktop's state like icon size are once again saved while the window state is not. Fixes #11864
Categories: Development

Tracker: Code simplication

Source Activity - Wed, 2015-02-25 20:31
Replace calls to dynamic_cast(this) != NULL with fIsDesktop which is the flag added to the constructor in e7803cf1f69a81b1c77880518ba16b6708c1efdb. We no longer need to do the expensive dynamic_cast's because we have a handy flag to check instead. Replace calls to dynamic_cast(this) != NULL with fIsDesktop which is the flag added to the constructor in e7803cf1f69a81b1c77880518ba16b6708c1efdb. We no longer need to do the expensive dynamic_cast's because we have a handy flag to check instead.
Categories: Development

Tracker: Small style fixes

Source Activity - Wed, 2015-02-25 20:01
Categories: Development

Ticket #11875 (Crash after quitting Haiku3D) created

Latest Bugs & Tasks - Wed, 2015-02-25 18:42

This is hrev48830.

Quitting Haiku3D there's a crash. Report attached. It starts with

state: Exception (Segment violation)
Frame		IP			Function Name
-----------------------------------------------
0x70aa2978	0xdbc2c4	/boot/system/lib/libGL.so + 0x2b2c4
Unable to retrieve disassembly for IP 0xdbc2c4: No such file or directory
	Frame memory:
		[0x70aa294c]  |6M.....D....).p   7c 36 4d 02 01 00 00 00 44 00 00 00 a8 29 aa 70
		[0x70aa295c]  ]6M...M.0....).p   5d 36 4d 02 08 81 4d 02 30 a4 0e 18 a8 29 aa 70
		[0x70aa296c]  .k...2......       f8 6b 82 01 a0 32 0f 18 03 00 00 00
0x70aa29b0	0x24d42c7	_._13BitmapTexture + 0x27
0x70aa29e0	0x1b0fb34	BReferenceable::LastReferenceReleased() + 0x2c
0x70aa2a10	0x1b0faf1	BReferenceable::ReleaseReference() + 0x3d
0x70aa2a40	0x24d1574	_._12MeshInstance + 0x24
0x70aa2a70	0x24d30c4	RenderView::_DeleteScene() + 0x38
0x70aa2ab0	0x24d243d	_._10RenderView + 0x2d
0x70aa2ae0	0x1a776a9	_._5BView + 0x95
0x70aa2b20	0x1a84cc5	_._7BWindow + 0xfd
0x70aa2b50	0x2317a69	_._13BDirectWindow + 0x35
0x70aa2b80	0x24d0f87	_._10MainWindow + 0x27
0x70aa2bb0	0x19a89bc	BLooper::Quit() + 0xdc
0x70aa2be0	0x1a85441	BWindow::Quit() + 0xc1
Categories: Development

Ticket #11874 ([HaikuDepot] crashed in FeaturedPackagesView::AddPackage()) created

Latest Bugs & Tasks - Wed, 2015-02-25 13:26

hrev48830.

I closed HaikuDepot with Alt+q while it was still populating featuring packages list and it crashed.

Categories: Development

[haiku] Re: Media add-on server failing (Augustin Cavalier)

Haiku Mailing List - Wed, 2015-02-25 03:45
This looks like a real bug. If you could create a ticket and attach this debug report along with what HREV you're on, that'd be much appreciated. -Augustin ...
Categories: Development

[haiku] Media add-on server failing (Ronald Copley)

Haiku Mailing List - Wed, 2015-02-25 03:45
Debug information for team /boot/system/servers/media_addon_server (662): CPU(s): 2x Intel Core 2 Memory: 3.90 GiB total, 269.83 MiB used Haiku revision: hrev48013 Oct 13 2014 16:31:29 (BePC) Active Threads: thread 662: media_addon_server (main) thread 669: _BMediaRoster_  thread 670: media_addon_server control  thread 671: System clock control  ...
Categories: Development

[haiku] Re: DiskUsage add-on may be broken (Adrien Destugues)

Haiku Mailing List - Wed, 2015-02-25 01:45
On Sat, Oct 11, 2014 at 10:03:24PM -0400, Ronald Copley wrote: For the last couple of updates, DiskUsage crashes when one brings the pointer over the diagram of the disk in its window. Crash log: Should be fixed in hrev48000. -- Adrien. ...
Categories: Development

[haiku] DiskUsage add-on may be broken (Ronald Copley)

Haiku Mailing List - Wed, 2015-02-25 01:45
For the last couple of updates, DiskUsage crashes when one brings the pointer over the diagram of the disk in its window. Crash log: Debug information for team /boot/system/apps/DiskUsage (748): CPU(s): 2x Intel Core 2 Memory: 3.90 GiB total, 255.73 MiB used Haiku revision: hrev47999 Oct 11 2014 17:04:00 (BePC) Active Threads: thread 748: DiskUsage (main) ...
Categories: Development
Syndicate content